[Qemu-devel] Re: [PATCH] Fix compiler warning on parsing the -usbdevice parameter

[Niels de Vos]

Ah, just noticed this warning is only in Jans git... For those who
were wondering :)

Cheers,
Niels

On 3/7/10, Niels de Vos <address@hidden> wrote:
> With the added checks on the parameter for -usbdevice, the following
> warning got introduced:
>
> hw/usb-bus.c: In function ‘usbdevice_create’:
> hw/usb-bus.c:278: error: assignment discards qualifiers from pointer target
> type
>
> It is okay to drop the qualifier (const) from the empty string here.
>
> Signed-off-by: Niels de Vos <address@hidden>
>
> diff --git a/hw/usb-bus.c b/hw/usb-bus.c
> index 89e2ea6..d058e14 100644
> --- a/hw/usb-bus.c
> +++ b/hw/usb-bus.c
> @@ -275,7 +275,7 @@ USBDevice *usbdevice_create(const char *cmdline)
>              len = sizeof(driver);
>          pstrcpy(driver, len, cmdline);
>      } else {
> -        params = "";
> +        params = (char*) "";
>          pstrcpy(driver, sizeof(driver), cmdline);
>      }
>