[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in hu
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] Re: [PATCH 28/50] error: Let converted handlers print in human monitor |
Date: |
Thu, 4 Mar 2010 18:14:22 -0300 |
On Thu, 04 Mar 2010 22:06:42 +0100
Markus Armbruster <address@hidden> wrote:
> Luiz Capitulino <address@hidden> writes:
>
> > On Thu, 4 Mar 2010 16:56:49 +0100
> > Markus Armbruster <address@hidden> wrote:
> >
> >> While fully converted handlers are not supposed to print anything when
> >> running in a QMP monitor, they are free to print in a human monitor.
> >
> > I disagree.
> >
> > One of the key decisions behind the new Monitor design is that handlers
> > are part of common code. User printing is output-specific and should not
> > be done by handlers.
> >
> > One of the problems with this layer violation is that the consumer of this
> > data might not be what you have assumed. For example, it has been suggested
> > that we could move the qemu shell out of qemu in the future. In this case,
> > this kind of information _could_ be useful.
>
> How do you intend to solve the problem of printing help then?
Doesn't a shallow conversion takes care of it for now?
> The perfect is the enemy of the good.
>
> > Another important problem is that free printing like this is error-prone
> > as it's not at all clear what could be printed and there's no way to catch
> > mistakes mechanically. Not to mention that this is for sure going to used
> > by those who want to ignore QMP completely.
>
> This paragraph I don't get.
If something that should be available under qmp is printed by using
monitor_printf(), we loose big time.
- [Qemu-devel] [PATCH 20/50] error: Track locations in configuration files, (continued)
- [Qemu-devel] [PATCH 20/50] error: Track locations in configuration files, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 46/50] qemu-option: Move the implied first name into QemuOptsList, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 22/50] error: Track locations on command line, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 48/50] monitor: New argument type 'O', Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 29/50] error: Polish human-readable error descriptions, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 21/50] QemuOpts: Fix qemu_config_parse() to catch file read errors, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 32/50] qdev: convert setting device properties to QError, Markus Armbruster, 2010/03/04
- [Qemu-devel] [PATCH 28/50] error: Let converted handlers print in human monitor, Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 44/50] error: Convert do_device_add() to QError, Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 37/50] qdev: Convert qbus_find() to QError, Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 43/50] Revert "qdev: Use QError for 'device not found' error", Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 33/50] qdev: Relax parsing of bus option, Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 50/50] monitor: convert do_device_add() to QObject, Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 27/50] monitor: New monitor_cur_is_qmp(), Markus Armbruster, 2010/03/04
[Qemu-devel] [PATCH 30/50] error: New QERR_PROPERTY_NOT_FOUND, Markus Armbruster, 2010/03/04