[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp
From: |
Gleb Natapov |
Subject: |
[Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp |
Date: |
Wed, 3 Mar 2010 18:00:22 +0200 |
On Mon, Mar 01, 2010 at 06:17:22PM +0100, Jan Kiszka wrote:
> As we hard-wire the BSP to CPU 0 anyway and cpuid_apic_id equals
> cpu_index, cpu_is_bsp can also be based on the latter directly. This
> will help an early user of it: KVM while initializing mp_state.
>
> Signed-off-by: Jan Kiszka <address@hidden>
> ---
> hw/pc.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index b90a79e..58c32ea 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -767,7 +767,8 @@ static void pc_init_ne2k_isa(NICInfo *nd)
>
> int cpu_is_bsp(CPUState *env)
> {
> - return env->cpuid_apic_id == 0;
> + /* We hard-wire the BSP to the first CPU. */
> + return env->cpu_index == 0;
> }
We should not assume that. The function was written like that
specifically so the code around it will not rely on this assumption.
Now you change that specifically to write code that will do incorrect
assumptions. I don't see the logic here.
>
> CPUState *pc_new_cpu(const char *cpu_model)
> --
> 1.6.0.2
--
Gleb.
- [Qemu-devel] [PATCH v4 09/10] qemu-kvm: Move kvm_set_boot_cpu_id, (continued)
- [Qemu-devel] [PATCH v4 09/10] qemu-kvm: Move kvm_set_boot_cpu_id, Jan Kiszka, 2010/03/01
- [Qemu-devel] [PATCH v4 05/10] KVM: x86: Restrict writeback of VCPU state, Jan Kiszka, 2010/03/01
- [Qemu-devel] [PATCH v4 04/10] qemu-kvm: Clean up mpstate synchronization, Jan Kiszka, 2010/03/01
- [Qemu-devel] [PATCH v4 08/10] qemu-kvm: Clean up KVM's APIC hooks, Jan Kiszka, 2010/03/01
- [Qemu-devel] [PATCH v4 02/10] qemu-kvm: Rework VCPU state writeback API, Jan Kiszka, 2010/03/01
- [Qemu-devel] [PATCH v4 06/10] qemu-kvm: Use VCPU event state for reset and vmsave/load, Jan Kiszka, 2010/03/01
- [Qemu-devel] [PATCH v4 01/10] qemu-kvm: Add KVM_CAP_X86_ROBUST_SINGLESTEP-awareness, Jan Kiszka, 2010/03/01
- [Qemu-devel] [PATCH v4 07/10] qemu-kvm: Cleanup/fix TSC and PV clock writeback, Jan Kiszka, 2010/03/01
- [Qemu-devel] [PATCH v4 10/10] qemu-kvm: Bring qemu_init_vcpu back home, Jan Kiszka, 2010/03/01
- [Qemu-devel] [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp, Jan Kiszka, 2010/03/01
- [Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp,
Gleb Natapov <=
- [Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp, Jan Kiszka, 2010/03/03
- [Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp, Gleb Natapov, 2010/03/04
- [Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp, Jan Kiszka, 2010/03/04
- [Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp, Gleb Natapov, 2010/03/04
- [Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp, Jan Kiszka, 2010/03/04
- [Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp, Gleb Natapov, 2010/03/04
- [Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp, Gleb Natapov, 2010/03/07
- [Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp, Jan Kiszka, 2010/03/07
- [Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp, Jan Kiszka, 2010/03/07
- [Qemu-devel] Re: [PATCH v4 03/10] x86: Extend validity of cpu_is_bsp, Gleb Natapov, 2010/03/07