[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCHv3 16/20] eepro100: Use tx.status
From: |
Stefan Weil |
Subject: |
[Qemu-devel] [PATCHv3 16/20] eepro100: Use tx.status |
Date: |
Tue, 2 Mar 2010 22:37:56 +0100 |
There is no need for a local variable "status".
Using tx.status makes it clearer which status
is addressed.
Signed-off-by: Stefan Weil <address@hidden>
---
hw/eepro100.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/eepro100.c b/hw/eepro100.c
index cf4e0ac..f5aa306 100644
--- a/hw/eepro100.c
+++ b/hw/eepro100.c
@@ -903,10 +903,10 @@ static void action_command(EEPRO100State *s)
for (;;) {
s->cb_address = s->cu_base + s->cu_offset;
cpu_physical_memory_read(s->cb_address, (uint8_t *)&s->tx,
sizeof(s->tx));
- uint16_t status = le16_to_cpu(s->tx.status);
uint16_t command = le16_to_cpu(s->tx.command);
+ s->tx.status = le16_to_cpu(s->tx.status);
logout("val=(cu start), status=0x%04x, command=0x%04x, link=0x%08x\n",
- status, command, s->tx.link);
+ s->tx.status, command, s->tx.link);
bool bit_el = ((command & COMMAND_EL) != 0);
bool bit_s = ((command & COMMAND_S) != 0);
bool bit_i = ((command & COMMAND_I) != 0);
@@ -950,7 +950,7 @@ static void action_command(EEPRO100State *s)
break;
}
/* Write new status. */
- stw_phys(s->cb_address, status | STATUS_C | (success ? STATUS_OK : 0));
+ stw_phys(s->cb_address, s->tx.status | STATUS_C | (success ? STATUS_OK
: 0));
if (bit_i) {
/* CU completed action. */
eepro100_cx_interrupt(s);
--
1.7.0
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] [PATCHv3 16/20] eepro100: Use tx.status,
Stefan Weil <=