Re: [Qemu-devel] [PATCH 1/3] Add FreeBSD/ppc host ppc_init_cacheline_sizes() implementation.

[malc]

On Tue, 16 Feb 2010, Juergen Lock wrote:

> On Tue, Feb 16, 2010 at 09:52:50AM +0300, malc wrote:
> > On Mon, 15 Feb 2010, Juergen Lock wrote:
> > 
> > > On Mon, Feb 15, 2010 at 06:16:07AM +0300, malc wrote:
> > > > On Sun, 14 Feb 2010, Juergen Lock wrote:
> > > > 
> > > > > Submitted by: Andreas Tobler <address@hidden>
> > > > > 
> > > > > Signed-off-by: Juergen Lock <address@hidden>
> > > > > 
> > > > > --- a/cache-utils.c
> > > > > +++ b/cache-utils.c
> > > > > @@ -57,6 +57,23 @@
> > > > >  }
> > > > >  #endif
> > > > >  
> > > > > +#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
> > > > 
> > > > __FreeBSD_kernel__ is for something like Debian/kFreeBSD?
> > > 
> > > Yep, it is.  Support for it was added to qemu some time ago so I
> > > figured I should do the same.
> > > 
> > 
> > Perhaps it would be better to avoid this particular ifdefery and
> > just go with _CALL_SYSV, can you verify that:
> > 
> > ~$ gcc -E -dM -x c /dev/null | grep SYSV
> > 
> > yields
> > 
> > #define _CALL_SYSV 1
> > 
> > on FreeBSD and Debian/kFreeBSD?
> 
> Nope, not found on FreeBSD.  (Also I would kinda doubt that sysctl is
> standardized?)

_CALL_SYSV means that calling convention is SysV one, nothing to do with
sysctl, and i wanted you/patch author to run it on FreeBSD/PPC...

-- 
mailto:address@hidden