|
From: | Anthony Liguori |
Subject: | [Qemu-devel] Re: [PATCH] Fix hanging user monitor when using balloon command |
Date: | Fri, 12 Feb 2010 14:50:44 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0 |
On 02/12/2010 02:14 PM, Adam Litke wrote:
Hi Anthony. I wonder if there was a problem when importing my async command handler patchset. Since the 'balloon' command completes immediately, it must call the completion callback before returning. That call was missing but is added by the patch below.
Needs a Signed-off-by. I don't recall any fuzz with your patch but that was a few hundred patches ago :-)
Regards, Anthony Liguori
diff --git a/monitor.c b/monitor.c index ae125b8..f94794d 100644 --- a/monitor.c +++ b/monitor.c @@ -2258,6 +2258,7 @@ static int do_balloon(Monitor *mon, const QDict *params, return -1; } + cb(opaque, NULL); return 0; }
[Prev in Thread] | Current Thread | [Next in Thread] |