[Qemu-devel] Re: [PATCH] virtio-spec: document MSI-X

[Michael S. Tsirkin]

On Fri, Feb 12, 2010 at 08:17:55PM +1030, Rusty Russell wrote:
> On Fri, 12 Feb 2010 03:52:36 am Michael S. Tsirkin wrote:
> > This documents MSI-X support in virtio.
> > 
> > Signed-off-by: Michael S. Tsirkin <address@hidden>
> 
> Wow, great!
> 
> I reworked one paragraph for better grammar.  Mainly adding "the":
> 
> (pseudo-patch):
>     Devices report such failures by returning +the+ NO_VECTOR value
>     when the relevant Vector field is read. After mapping an event to vector,
>     +the+ driver must verify success by reading the Vector field value: on
>     success, +the+ previously written value is returned-;-+, and+ on failure,
>     NO_VECTOR -value- is returned. If +a+ mapping failure is detected, +the+
>     driver can retry mapping with +fewer+-less- vectors, or disable MSI-X.

Looks good, thanks for the corrections!

> I really liked the conversational style: standards can be intimidating and
> unfriendly documents if they concentrate too much on partitioning all
> information into precise sections.
> 
> That makes it 0.8.6.  I will re-read the entire document for consistency
> before releasing 0.9.
> 
> Thanks!
> Rusty.