[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v2 00/21] qemu-kvm: Hook cleanups and extended u
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH v2 00/21] qemu-kvm: Hook cleanups and extended use of upstream code |
Date: |
Sun, 07 Feb 2010 12:28:49 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Gleb Natapov wrote:
> On Wed, Feb 03, 2010 at 09:53:25AM +0100, Jan Kiszka wrote:
>> This version addresses the feedback on v2, namely:
>> - assert(<vm stopped> || <current thread == env->thread>) on low-level
>> load/save registers
>> - fixed mpstate initialization
>>
> With those patched, doing "info cpus" in monitor kill the guest, which,
> unfortunately, means that reworked VCPU state writeback is still not so
> easy to use correctly.
>
Regression of patch 12 ("qemu-kvm: Use upstream kvm_vcpu_dirty"), will
be fixed in v3.
Thanks,
Jan
---
diff --git a/qemu-kvm.c b/qemu-kvm.c
index 6a72b89..72c2ca0 100644
--- a/qemu-kvm.c
+++ b/qemu-kvm.c
@@ -1532,13 +1532,13 @@ static void do_kvm_cpu_synchronize_state(void *_env)
CPUState *env = _env;
kvm_arch_save_regs(env);
+ env->kvm_vcpu_dirty = 1;
}
void kvm_cpu_synchronize_state(CPUState *env)
{
if (!env->kvm_vcpu_dirty) {
on_vcpu(env, do_kvm_cpu_synchronize_state, env);
- env->kvm_vcpu_dirty = 1;
}
}
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] Re: [PATCH v2 14/21] qemu-kvm: Rework VCPU state writeback API, (continued)
[Qemu-devel] Re: [PATCH v2 00/21] qemu-kvm: Hook cleanups and extended use of upstream code, Marcelo Tosatti, 2010/02/03
[Qemu-devel] Re: [PATCH v2 00/21] qemu-kvm: Hook cleanups and extended use of upstream code, Gleb Natapov, 2010/02/07
- [Qemu-devel] Re: [PATCH v2 00/21] qemu-kvm: Hook cleanups and extended use of upstream code,
Jan Kiszka <=