[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/5] socket: Add a reconnect option.
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 2/5] socket: Add a reconnect option. |
Date: |
Mon, 1 Feb 2010 14:12:51 -0200 |
On Mon, 01 Feb 2010 09:25:27 -0600
Anthony Liguori <address@hidden> wrote:
> On 02/01/2010 07:34 AM, Ian Molton wrote:
> > Add a reconnect option that allows sockets to reconnect (after a
> > specified delay) to the specified server. This makes the virtio-rng driver
> > useful in production environments where the EGD server may need to be
> > restarted.
> >
> > Signed-off-by: Ian Molton<address@hidden>
> >
>
> I went back and looked at the last series and found my feedback. I had
> suggested that instead of automatically reconnecting, a mechanism should
> be added for a user to initiate a reconnect.
>
> Additionally, we should emit events upon disconnect through QMP (now
> that we have that functionality).
Should we merge all disconnect events or should we keep them
separated?
I mean, we currently have VNC_DISCONNECT and will likely have
SPICE_DISCONNECT. Maybe we could have a SOCKET_DISCONNECT and have
a 'source' member, like:
{ "event": "SOCKET_DISCONNECT", "data": { "source": "vnc" ... } }
I can see two drawbacks:
1. We can't do this for connects, which will make this inconsistent
2. Its "data" member is dependent on the source, which makes this
event return a set of different info (say vnc auth types vs. auth
types)
So, I'd keep them separated.
- [Qemu-devel] [PATCH 3/5] Add SIZE type to qdev properties, (continued)
- [Qemu-devel] [PATCH 3/5] Add SIZE type to qdev properties, Ian Molton, 2010/02/01
- [Qemu-devel] [PATCH 4/5] virtio: Add virtio-rng driver, Ian Molton, 2010/02/01
- [Qemu-devel] [PATCH 5/5] Build fix (missing header), Ian Molton, 2010/02/01
- Re: [Qemu-devel] [PATCH 4/5] virtio: Add virtio-rng driver, Anthony Liguori, 2010/02/01
- Re: [Qemu-devel] [PATCH 4/5] virtio: Add virtio-rng driver, Gerd Hoffmann, 2010/02/01
- Re: [Qemu-devel] [PATCH 4/5] virtio: Add virtio-rng driver, Anthony Liguori, 2010/02/01
- Re: [Qemu-devel] [PATCH 4/5] virtio: Add virtio-rng driver, Ian Molton, 2010/02/01
- Re: [Qemu-devel] [PATCH 4/5] virtio: Add virtio-rng driver, Ian Molton, 2010/02/01
- Re: [Qemu-devel] [PATCH 4/5] virtio: Add virtio-rng driver, Ian Molton, 2010/02/09
- Re: [Qemu-devel] [PATCH 2/5] socket: Add a reconnect option., Anthony Liguori, 2010/02/01
- Re: [Qemu-devel] [PATCH 2/5] socket: Add a reconnect option.,
Luiz Capitulino <=
- Re: [Qemu-devel] [PATCH 2/5] socket: Add a reconnect option., Anthony Liguori, 2010/02/01
- Re: [Qemu-devel] [PATCH 2/5] socket: Add a reconnect option., Ian Molton, 2010/02/01
- Re: [Qemu-devel] [PATCH 2/5] socket: Add a reconnect option., Anthony Liguori, 2010/02/01
- Re: [Qemu-devel] [PATCH 2/5] socket: Add a reconnect option., Ian Molton, 2010/02/02