Re: [Qemu-devel] [PATCH 3/4] Add -defaults option to allow default devices to be overridden

[Markus Armbruster]

Anthony Liguori <address@hidden> writes:

> This option can be used to toggle whether each default device is enabled or
> disabled.  For character devices, the default backend can also be overridden.
>
> For devices, we'll have to take a different approach to changing the defaults
> which will be covered in the next patch.
>
> N.B. I took special care with -nographic.  Now -nographic pretty clearly acts
> as a mechanism to override the default backend devices.
>
> Signed-off-by: Anthony Liguori <address@hidden>
> ---
>  qemu-config.c   |   45 +++++++++++++++++++++++++++++++++
>  qemu-config.h   |    1 +
>  qemu-options.hx |    7 +++++
>  vl.c            |   75 
> +++++++++++++++++++++++++++++++++++++++++--------------
>  4 files changed, 109 insertions(+), 19 deletions(-)
>
> diff --git a/qemu-config.c b/qemu-config.c
> index c3203c8..82ca399 100644
> --- a/qemu-config.c
> +++ b/qemu-config.c
> @@ -242,6 +242,50 @@ QemuOptsList qemu_mon_opts = {
>      },
>  };
>  
> +QemuOptsList qemu_default_opts = {
> +    .name = "default",
> +    .head = QTAILQ_HEAD_INITIALIZER(qemu_default_opts.head),
> +    .desc = {
> +        {
> +            .name = "serial",
> +            .type = QEMU_OPT_STRING,
> +        },
[...]
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 57f453d..e81ecb5 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1919,6 +1919,13 @@ STEXI
>  Don't create default devices.
>  ETEXI
>  
> +DEF("default", HAS_ARG, QEMU_OPTION_default, \
> +    "-default arg    specify default devices\n")

Isn't this too terse?

> +STEXI
> address@hidden -defaults
> +Override builtin default devices
> +ETEXI

This *is* too terse :)

Oh, and it's -default (sans 's').  Same typo in subject.

While we're talking about naming: isn't -default a bit too generic a
name for something that manipulates devices?  Not sure we care, as
-nodefaults is much worse, already.

[...]