qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: Stop using "which" in ./configure


From: Paolo Bonzini
Subject: [Qemu-devel] Re: Stop using "which" in ./configure
Date: Thu, 21 Jan 2010 21:12:58 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0

On 01/21/2010 05:53 PM, Jamie Lokier wrote:
>  If you make that IFS=${local_ifs:-$(printf ' \t\n')} it should be safe.
>  Likewise if you set the value first.
Remove the colon.  The above will wrongly change empty IFS, which
is not the same as unset IFS.

local_ifs would never be unset anyway, so it would never trigger.

After all, Loic's code can be considered okay as it was in the first place (sorry). Instead, we should just make sure that no code ever unsets IFS. I committed this recommendation to the Autoconf manual's shell portability section, so it's not necessary to add any comment here.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]