[Qemu-devel] Re: [PATCH] rtl8139: fix clang reporting unused assignment of VLAN tagging data

[Paolo Bonzini]

> diff --git a/hw/rtl8139.c b/hw/rtl8139.c
> index 1f4f585..f04dd54 100644
> --- a/hw/rtl8139.c
> +++ b/hw/rtl8139.c
> @@ -1909,6 +1909,7 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s)
>
>       cpu_physical_memory_read(cplus_tx_ring_desc,    (uint8_t *)&val, 4);
>       txdw0 = le32_to_cpu(val);
> +    /* TODO: implement VLAN tagging support, VLAN tag data is read to txdw1 */
>       cpu_physical_memory_read(cplus_tx_ring_desc+4,  (uint8_t *)&val, 4);
>       txdw1 = le32_to_cpu(val);
>       cpu_physical_memory_read(cplus_tx_ring_desc+8,  (uint8_t *)&val, 4);
> @@ -1920,6 +1921,9 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s)
>              descriptor,
>              txdw0, txdw1, txbufLO, txbufHI));
>
> +    /* TODO: the following discard cast should clean clang analyzer output */
> +    (void)txdw1;

I don't like this, why not comment it out like here:

> +    /* TODO: implement VLAN tagging support, VLAN tag data is read to txdw1 */
>   //    val = cpu_to_le32(txdw1);
>   //    cpu_physical_memory_write(cplus_tx_ring_desc+4,&val, 4);

(and maybe change this one as well to #if 0...#endif, I don't know).

Paolo