Re: [Qemu-devel] [PATCHv7 3/3] virtio: add features as qdev properties

[Michael S. Tsirkin]

On Tue, Jan 12, 2010 at 07:09:27PM +0100, Christoph Hellwig wrote:
> This patch causes 100% reproducible boot panics in a Linux guest using
> virtio.
> 
> My qemu command line is:
> 
> /opt/qemu/bin/qemu-system-x86_64 \
>         -m 1500 \
>       -enable-kvm \
>       -drive 
> file=/dev/vg00/qemu-root,if=virtio,media=disk,cache=none,aio=threads \
>       -kernel arch/x86/boot/bzImage \
>       -append "root=/dev/vda console=tty0 console=ttyS0,38400n8" \
>       -nographic
> 
> and the guest dmesg is:

So the issue is that wrong block size (0xffffffff) was passed
to guest.  Would it make sense to add some sanity checking in virtio-blk
to make it not crash but fail in probe? Which block size values
are sane?

-- 
MST