Re: [Qemu-devel] [PATCH 1/2] block: clean up bdrv_open2 structure a bit

[Christoph Hellwig]

On Tue, Jan 12, 2010 at 05:04:00PM +0100, Kevin Wolf wrote:
> To keep the behaviour as previously you'd need to set at least bs->drv
> in the unlink_and_fail case, too. I have no clue why it's important to
> set it to NULL when bs isn't going to be used anyway (probably it is,
> but I don't know where), but Fabrice committed this in 6b21b973 as a
> fix. Unfortunately, the commit message looks like most of Fabrice's
> commit messages, so it's of no use for me...

The unlink_and_fail label can only be reached from places where we
haven't set bs->drv yet, so it should be fine.