qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Workaround for broken OSS_GETVERSION on FreeBSD


From: Juergen Lock
Subject: Re: [Qemu-devel] [PATCH] Workaround for broken OSS_GETVERSION on FreeBSD, part two
Date: Sun, 10 Jan 2010 19:57:38 +0100
User-agent: Mutt/1.5.20 (2009-06-14)

On Sun, Jan 10, 2010 at 01:40:18AM +0300, malc wrote:
> On Sat, 9 Jan 2010, Juergen Lock wrote:
> 
> > Turns out on those versions of FreeBSD (>= 7.x) that know OSS_GETVERSION
> > the ioctl doesn't actually work yet (except in the Linuxolator), so if
> > building on FreeBSD fall back to using SOUND_VERSION as defined in
> > <sys/soundcard.h> (which atm is 0x040000) if the ioctl is defined but
> > fails.
> 
> I've changed the code in the meantime, so this wont apply. Also this
> is wrong version is dynamic by nature, if someone runs qemu on FreeBSD
> where SOUND_VERSION is less than 4, things will get ugly.
> 
Yes but running packages on an older FreeBSD version than they were
built on isn't really supported (read: won't work, especially if its
an older major branch too like in this case.)  On top of that,
SOUND_VERSION was bumped to 0x040000 for FreeBSD 7.0 already (the
commit is from 2006), and FreeBSD 6 is nothing more than a legacy
branch now that I think few ppl still use (or at least for things
like qemu), the last release was FreeBSD 8.0...

> In the new code i mentioned one can opt for not considering POLICY
> failure a hard error and proceed with a SETFRAGMENT path, which is
> what i would prefer to see on FreeBSD.
> 
 Anyway, you are the qemu audio maintainer, so if thats really what
you prefer, fine with me. :)

 Cheers,
        Juergen




reply via email to

[Prev in Thread] Current Thread [Next in Thread]