|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] [PATCH] Add KVM paravirt cpuid leaf |
Date: | Thu, 07 Jan 2010 10:53:30 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0 |
On 01/07/2010 10:15 AM, Gleb Natapov wrote:
KVM_CPUID_SIGNATURE is unnecessary as a guard because it's always been present in kvm_para.h. Since we include kvm_para.h unconditionally, there's no way we wouldn't have KVM_CPUID_SIGNATURE.It is there in qemu-kvm and we suppose to bring knowledge from there :)
Hopefully just the good bits.
But I can drop it if you like.
I don't want to deviate unnecessarily from qemu-kvm so we can approach this in one of two ways. We can remove the guard in qemu-kvm and Avi can send me a pull request with this feature. I can also just pull in the patch as-is and we can fix this in both places later. I'm happy either way.
Regards, Anthony Liguori
-- Gleb.
[Prev in Thread] | Current Thread | [Next in Thread] |