qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 11/19] use a bottom half to run timers


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 11/19] use a bottom half to run timers
Date: Tue, 05 Jan 2010 09:38:58 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0

On 01/04/2010 08:38 PM, Jamie Lokier wrote:
In principle, if it does affect something, it seems likely there is
already a buggy race condition.  After all, if the timer and bottom
half could trigger at the same time, which is the condition where the
order is significant, then in principle the timer could have triggered
slightly later because it depends on the host alarm behaviour.

No, the problem is when the timer function is _itself_ scheduling a bottom half. Before my patch there was a guarantee that the bh would run before TCG, now there is not. It can be fixed easily though.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]