Re: [Qemu-devel] [PATCH] add "info ioapic" monitor command

[Anthony Liguori]

On 12/31/2009 09:39 AM, Gleb Natapov wrote:
> > The common case is where you just want to see the state of the
> > device. We support hundreds of devices.  We can have one code path
> > that displays 95% of them with a couple devices that have exceptions
> > or we could have hundreds of these commands that aren't consistent
> > because they're all open-coded.
> I am not against having common code path that prints out state of all
> devices. It just different from what I am trying to achieve with my patch.
> My patch adds parsing and pretty-printing of device state and that's the
> part that is not addressed with your common code scenario.

A common device printing mechanism is probably no more code than your 
current patch.

My position is that if that generic mechanism is not good enough for 
you, then we should look at fixing that problem instead of introducing a 
completely redundant mechanism.

Heck, even if you had a generic mechanism and then a big if in the 
middle of it that treated ioapic better than other devices, it would be 
100x better than introducing a 1-off command.

Regards,

Anthony Liguori

> >   In some case machine
> > > printing of vmstate will show you the history of that devices live
> > > migration bug fixes in addition to its state.
> >
> > I don't see this as a bad thing.
> >
> > Regards,
> >
> > Anthony Liguori
>
> --
>                         Gleb.