[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command |
Date: |
Wed, 30 Dec 2009 11:25:39 -0200 |
On Wed, 30 Dec 2009 12:01:28 +0000
Blue Swirl <address@hidden> wrote:
> On Wed, Dec 30, 2009 at 11:50 AM, Gleb Natapov <address@hidden> wrote:
> > Knowing ioapic configuration is very useful for the poor soles
> > how need to debug guest occasionally.
>
> > +static struct IOAPICState *ioapic;
>
> Ugly. I really think the monitor interface needs to be changed to take
> an opaque parameter.
>
> The parameter can passed to the caller with for example a registration
> function, like the patches I sent before QObject conversion.
Do you mind updating your series and sending it again?
You could make the opaque parameter part of info_new or cmd_new, provided
the new handlers have global data so that we can see better the benefit
in practice.
- [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Gleb Natapov, 2009/12/30
- Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Blue Swirl, 2009/12/30
- Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Gleb Natapov, 2009/12/30
- Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Izik Eidus, 2009/12/30
- Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Gleb Natapov, 2009/12/30
- Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Anthony Liguori, 2009/12/30
- Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Gleb Natapov, 2009/12/30
- Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Anthony Liguori, 2009/12/31
- Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Gleb Natapov, 2009/12/31
Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command,
Luiz Capitulino <=
[Qemu-devel] Re: [PATCHv2] add "info ioapic" monitor command, Luiz Capitulino, 2009/12/30
Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Avi Kivity, 2009/12/30
- Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Gleb Natapov, 2009/12/30
- Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Avi Kivity, 2009/12/30
- Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Anthony Liguori, 2009/12/30
- Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Gleb Natapov, 2009/12/30
- Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Anthony Liguori, 2009/12/31
- Re: [Qemu-devel] [PATCHv2] add "info ioapic" monitor command, Gleb Natapov, 2009/12/31