[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: commit rules for common git tree
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: commit rules for common git tree |
Date: |
Wed, 30 Dec 2009 15:11:55 +0200 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Sun, Dec 27, 2009 at 05:01:38PM -0600, Anthony Liguori wrote:
> I think it's a good idea to use the mailing list whenever possible.
> Likewise, if you see a patch go in that you think would have benefited
> from being on the list, point it out.
Sometimes it would have benefited *others* if the patch was posted
(either before or after commit). Consider commit:
commit 3caf2562c21278aa9992bc7e6b5bbe98bc79f92e
Author: malc <address@hidden>
Date: Wed Dec 30 04:26:34 2009 +0300
sdl: print the reason why SDL thinks SDL_Init failed before exiting
Signed-off-tby: malc <address@hidden>
So after this is applied, we print out failure reason which is good.
But this was only applied on master, and I think this patch would be
good to have on 0.12 and even 0.11 branches: it is very safe, and SDL
init failures are a FAQ.
I hope this illustrates how it is good to post even obvious patches
to the list.
--
- [Qemu-devel] Re: commit rules for common git tree, (continued)
- [Qemu-devel] Re: commit rules for common git tree, Michael S. Tsirkin, 2009/12/27
- [Qemu-devel] Re: commit rules for common git tree, Aurelien Jarno, 2009/12/27
- [Qemu-devel] Re: commit rules for common git tree, Michael S. Tsirkin, 2009/12/27
- [Qemu-devel] Re: commit rules for common git tree, Anthony Liguori, 2009/12/27
- [Qemu-devel] Re: commit rules for common git tree, Michael S. Tsirkin, 2009/12/28
- [Qemu-devel] Re: commit rules for common git tree, Michael S. Tsirkin, 2009/12/29
- [Qemu-devel] Re: commit rules for common git tree, Aurelien Jarno, 2009/12/29
- [Qemu-devel] Re: commit rules for common git tree, Michael S. Tsirkin, 2009/12/29
- [Qemu-devel] Re: commit rules for common git tree, Aurelien Jarno, 2009/12/29
- [Qemu-devel] Re: commit rules for common git tree, Michael S. Tsirkin, 2009/12/30
- [Qemu-devel] Re: commit rules for common git tree,
Michael S. Tsirkin <=
Re: [Qemu-devel] Re: commit rules for common git tree, Scott Tsai, 2009/12/27
[Qemu-devel] Re: commit rules for common git tree, Anthony Liguori, 2009/12/27
- [Qemu-devel] Re: commit rules for common git tree, Michael S. Tsirkin, 2009/12/27
- [Qemu-devel] Re: commit rules for common git tree, Anthony Liguori, 2009/12/27
- Re: [Qemu-devel] Re: commit rules for common git tree, Avi Kivity, 2009/12/28
- Re: [Qemu-devel] Re: commit rules for common git tree, Michael S. Tsirkin, 2009/12/28
- Re: [Qemu-devel] Re: commit rules for common git tree, Aurelien Jarno, 2009/12/28
- Re: [Qemu-devel] Re: commit rules for common git tree, Michael S. Tsirkin, 2009/12/28