[Qemu-devel] Re: commit rules for common git tree

[Michael S. Tsirkin]

On Sun, Dec 27, 2009 at 05:01:38PM -0600, Anthony Liguori wrote:
> I think it's a good idea to use the mailing list whenever possible.  
> Likewise, if you see a patch go in that you think would have benefited  
> from being on the list, point it out.

Sometimes it would have benefited *others* if the patch was posted
(either before or after commit). Consider commit:

        commit 3caf2562c21278aa9992bc7e6b5bbe98bc79f92e
        Author: malc <address@hidden>
        Date:   Wed Dec 30 04:26:34 2009 +0300

            sdl: print the reason why SDL thinks SDL_Init failed before exiting

            Signed-off-tby: malc <address@hidden>

So after this is applied, we print out failure reason which is good.
But this was only applied on master, and I think this patch would be
good to have on 0.12 and even 0.11 branches: it is very safe, and SDL
init failures are a FAQ.

I hope this illustrates how it is good to post even obvious patches
to the list.

--