qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: commit rules for common git tree


From: Andreas Färber
Subject: Re: [Qemu-devel] Re: commit rules for common git tree
Date: Sun, 27 Dec 2009 19:24:36 +0100


Am 27.12.2009 um 17:12 schrieb Blue Swirl:

On Sun, Dec 27, 2009 at 11:37 AM, Michael S. Tsirkin <address@hidden> wrote:
2. When a change is committed to the tree, often no notification is sent
  to the author.
  Why is it a good idea to ask everyone to subscribe to qemu commits
  list as well? Can 'applied thanks' mail be sent to patch authors?

In the good old times, CVS commit messages went also to qemu-devel
list. That may no longer be technically possible or even desirable
because of the volume. I think qemu-commits sends the message to the
qemu-commits list and the author, so the 'applied, thanks' shouldn't
be needed if the list worked reliably.

Unfortunately it doesn't work most of the time, so one rarely knows whether a patch (series) is applied already a) for pulling and b) after pulling in midst of all the git-log noise. It's not just about one's own patches, it also affects ack'ing other people's patches. If there's no reply to a patch we can't tell whether it means no one has looked at it yet (so that ack'ing it makes sense) or whether it was immediately applied already.

Having an 'Applied, thanks' message as indicator in the thread on qemu- devel as in good old times is still useful since the emails once sent by qemu-commits had no relation to the original thread. Some of you do still reply, thanks for taking the time! Maybe in a git- am workflow such a one-line reply could even be automated based on the patch's Message-ID? :)

Andreas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]