[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/7] QMP: Assure that returned data is a QDict
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 3/7] QMP: Assure that returned data is a QDict |
Date: |
Tue, 22 Dec 2009 01:06:35 -0200 |
On Mon, 21 Dec 2009 19:21:18 +0000
Nathan Baum <address@hidden> wrote:
> On Fri, 2009-12-18 at 13:25 -0200, Luiz Capitulino wrote:
> > This is for debug purposes only.
>
> This breaks quite a lot of commands where the returned data is a QList,
> e.g. query-commands, query-mice, query-cpus. Is the assert wrong, or are
> such commands meant to be returning a QDict?
The assert is wrong, as we've defined that returning a QList of
QDicts is ok.
We could check for a QList too and check its contents but I think that
only dropping the assert is ok for now.
Will submit a patch and thanks for testing QMP.
- [Qemu-devel] [FOR 0.12 0/7]: More QMP related fixes, Luiz Capitulino, 2009/12/18
- [Qemu-devel] [PATCH 1/7] QMP: Only handle converted commands, Luiz Capitulino, 2009/12/18
- [Qemu-devel] [PATCH 2/7] QMP: Return an empty dict by default, Luiz Capitulino, 2009/12/18
- [Qemu-devel] [PATCH 3/7] QMP: Assure that returned data is a QDict, Luiz Capitulino, 2009/12/18
- [Qemu-devel] [PATCH 4/7] QMP: Update README file, Luiz Capitulino, 2009/12/18
- [Qemu-devel] [PATCH 5/7] QMP: Update spec file, Luiz Capitulino, 2009/12/18
- Re: [Qemu-devel] [PATCH 5/7] QMP: Update spec file, Luiz Capitulino, 2009/12/18
- Re: [Qemu-devel] [PATCH 5/7] QMP: Update spec file, Markus Armbruster, 2009/12/18
[Qemu-devel] [PATCH 6/7] monitor: Introduce 'M' argument type, Luiz Capitulino, 2009/12/18