|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] Re: [PATCH 5/6] tcg-i386: Simplify brcond2. |
Date: | Fri, 18 Dec 2009 09:45:30 -0800 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Thunderbird/3.0b4 |
On 12/18/2009 03:40 AM, Laurent Desnogues wrote:
I'm not sure I really like that rewrite, I find it hard to read. Convince me it's better :-)
Would it be more obvious if I used a table instead of a switch? The code size reduction is Num: Value Size Type Bind Vis Ndx Name before: 40: 000039a0 793 FUNC LOCAL DEFAULT 1 tcg_out_brcond2 after: 40: 00003a50 412 FUNC LOCAL DEFAULT 1 tcg_out_brcond2 table-ized: 40: 00003a50 224 FUNC LOCAL DEFAULT 1 tcg_out_brcond2But I'm not married to the patch; let's drop it if there's a question of it holding up the rest of the series.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |