Re: [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP

From:	Markus Armbruster
Subject:	Re: [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP
Date:	Tue, 15 Dec 2009 10:50:15 +0100
User-agent:	Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)

Luiz Capitulino <address@hidden> writes:

> The monitor_read_command() function is readline specific
> and should only be used when readline is available.
>
> Signed-off-by: Luiz Capitulino <address@hidden>

I figure this bug breaks password entry (VNC and block) on non-readline
monitors.  Suspect commit cde76ee1.

[Prev in Thread]

Current Thread

[Next in Thread]

[Qemu-devel] [FOR 0.12 0/5]: Misc QMP related fixes, Luiz Capitulino, 2009/12/14
- [Qemu-devel] [PATCH 1/5] QDict: Fix size update, Luiz Capitulino, 2009/12/14
- [Qemu-devel] [PATCH 2/5] monitor: Use 'device' in eject, Luiz Capitulino, 2009/12/14
- [Qemu-devel] [PATCH 3/5] monitor: do_balloon(): Check for errors, Luiz Capitulino, 2009/12/14
- [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP, Luiz Capitulino, 2009/12/14
  - Re: [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP, Markus Armbruster <=
    - Re: [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP, Markus Armbruster, 2009/12/15
    - Re: [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP, Luiz Capitulino, 2009/12/15
    - Re: [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP, Markus Armbruster, 2009/12/15
    - [Qemu-devel] Re: [PATCH 4/5] monitor: Avoid readline functions in QMP, Jan Kiszka, 2009/12/15
- [Qemu-devel] [PATCH 5/5] monitor: Catch printing to non-existent monitor, Luiz Capitulino, 2009/12/14
  - Re: [Qemu-devel] [PATCH 5/5] monitor: Catch printing to non-existent monitor, Markus Armbruster, 2009/12/15
    - Re: [Qemu-devel] [PATCH 5/5] monitor: Catch printing to non-existent monitor, Luiz Capitulino, 2009/12/15
    - Re: [Qemu-devel] [PATCH 5/5] monitor: Catch printing to non-existent monitor, Markus Armbruster, 2009/12/15

Prev by Date: Re: [Qemu-devel] [PATCH 5/5] monitor: Catch printing to non-existent monitor
Next by Date: Re: [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP
Previous by thread: [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP
Next by thread: Re: [Qemu-devel] [PATCH 4/5] monitor: Avoid readline functions in QMP
Index(es):
- Date
- Thread