[Qemu-devel] Re: -serial stdio broken

[Blue Swirl]

On Mon, Dec 14, 2009 at 10:55 AM, Gerd Hoffmann <address@hidden> wrote:
> On 12/13/09 10:38, Blue Swirl wrote:
>>
>> On Sun, Dec 13, 2009 at 8:24 AM, Blue Swirl<address@hidden>  wrote:
>>>
>>> I guess e1c09175bc00dd8dfb2ad1b26e1858dcdc109b59 or
>>> 998bbd74b9d813b14a3a3b5009a5d5a48c7dce51 broke -serial stdio for all
>>> targets:
>>> qemu -serial stdio -monitor stdio
>
> Oh.  It is actually used on the command line.  Hmm.
>
> First, you can use '-serial mon:stdio' instead.
>
> Second, with 'qemu -nographic' you don't need to specify this at all because
> that is the default.
>
> What is gone now is the automagic conversion of '-serial stdio -monitor
> stdio' into '-serial mon:stdio' because I didn't expect people actually
> using that on the command line (see commit message).  Also this kind of
> post-processing is pretty horrible thing for the command line parser code.
>  Thus I would pretty much prefer to not re-introduce this ...

It looks like vl.c was a poor place to do the mux choice. I just
wonder why mux option can't be automatically enabled for stdio in
qemu-char.c:qemu_chr_parse_compat() or somewhere nearby.

> Can you live with one of the alternatives outlined above?

I removed -monitor stdio from all my tests, now they work.