[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH, try 2, version 2] qemu/tap: add -net tap, d
From: |
Arnd Bergmann |
Subject: |
Re: [Qemu-devel] Re: [PATCH, try 2, version 2] qemu/tap: add -net tap, dev= option |
Date: |
Wed, 9 Dec 2009 16:48:20 +0100 |
User-agent: |
KMail/1.12.2 (Linux/2.6.31-14-generic; KDE/4.3.2; x86_64; ; ) |
On Wednesday 09 December 2009, Michael S. Tsirkin wrote:
> On Wed, Dec 09, 2009 at 03:49:04PM +0100, Arnd Bergmann wrote:
> >
> > - TFR(fd = open("/dev/net/tun", O_RDWR));
> > + if (!*dev)
> > + dev = "/dev/net/tun";
> > +
>
> Did you test without dev parameter? I think dev will be NULL
> so this will deference a nullpointer ...
> probably if (!dev) is what you mean?
D'oh. will fix.
> will be neater if you put [,dev=str] after [,script=file]
> Also - it does need a string, but only insofar as all options are strings.
> Maybe dev=devfile or dev=file would be clearer.
Yep. Thanks,
Arnd
- [Qemu-devel] [PATCH, try 2] qemu/tap: add -net tap,dev= option, Arnd Bergmann, 2009/12/08
- Re: [Qemu-devel] [PATCH, try 2] qemu/tap: add -net tap,dev= option, Mark McLoughlin, 2009/12/09
- [Qemu-devel] Re: [PATCH, try 2] qemu/tap: add -net tap,dev= option, Michael S. Tsirkin, 2009/12/09
- [Qemu-devel] Re: [PATCH, try 2] qemu/tap: add -net tap,dev= option, Arnd Bergmann, 2009/12/09
- Re: [Qemu-devel] Re: [PATCH, try 2] qemu/tap: add -net tap, dev= option, Christoph Egger, 2009/12/09
- [Qemu-devel] Re: [PATCH, try 2] qemu/tap: add -net tap,dev= option, Michael S. Tsirkin, 2009/12/09
- [Qemu-devel] [PATCH, try 2, version 2] qemu/tap: add -net tap, dev= option, Arnd Bergmann, 2009/12/09
- [Qemu-devel] Re: [PATCH, try 2, version 2] qemu/tap: add -net tap, dev= option, Michael S. Tsirkin, 2009/12/09
- Re: [Qemu-devel] Re: [PATCH, try 2, version 2] qemu/tap: add -net tap, dev= option,
Arnd Bergmann <=
[Qemu-devel] Re: [PATCH, try 2] qemu/tap: add -net tap,dev= option, Anthony Liguori, 2009/12/09