|
From: | Gerd Hoffmann |
Subject: | [Qemu-devel] Re: [FOR 0.12 PATCH v3 05/21] default devices: core code & serial lines. |
Date: | Mon, 07 Dec 2009 14:27:24 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Lightning/1.0pre Thunderbird/3.0b4 |
On 12/07/09 13:52, Alexander Graf wrote:
diff --git a/vl.c b/vl.c index 24d5d92..eca4eee 100644 --- a/vl.c +++ b/vl.c @@ -271,6 +271,30 @@ uint8_t qemu_uuid[16]; static QEMUBootSetHandler *boot_set_handler; static void *boot_set_opaque; +static int default_serial = 1;Default variables belong in the machine description IMHO. On S390, we can't create serial, parallel or vga (or any MMIO/PIO requiring) devices.
See last patch of this series. Moving that into the machine description is certainly worth looking at. For now I'm happy that the #ifdef S390 code for the default virtio console is down to just two lines.
cheers Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |