qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Permit zero-sized qemu_malloc() & friends


From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH] Permit zero-sized qemu_malloc() & friends
Date: Sun, 06 Dec 2009 15:07:59 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091203 Fedora/3.0-3.13.rc2.fc12 Thunderbird/3.0

On 12/06/2009 01:25 AM, Ian Molton wrote:
Avi Kivity wrote:

It's not that it doesn't have a way to report failure, it's that it
doesn't fail.  Do you prefer functions that fail and report it to
functions that don't fail?
You have a way of allocating memory that will _never_ fail?


Sort of.  Did you look at the code?

Seriously, who does that anyway? why call malloc when you dont want the
space? so you can use realloc? 99.99% of the time realloc() is the Wrong
Solution(tm).

Read the beginning of the thread.  Basically it's for arrays, malloc(n *
sizeof(x)).
well, make sure n is not 0. Its not that hard. I dont think I've *ever*
had a situation where I wanted to pass 0 to malloc.

There are multiple such cases in the code.

stick to what people know, and LART them for misuse of it if necessary.
The LART is a crash, great.
No, the LART would be a 'your patch does this wrong, try this:'

What about existing usage?  Will you audit all the existing calls?

--
error compiling committee.c: too many arguments to function





reply via email to

[Prev in Thread] Current Thread [Next in Thread]