Re: [Qemu-devel] [PATCH] raw: Use the right host device driver for open/create

[Anthony Liguori]

Christoph Hellwig wrote:
> On Mon, Nov 30, 2009 at 04:54:31PM +0100, Kevin Wolf wrote:
>   
> > Users don't expect that they need to specify host_device/cdrom/floppy when
> > "creating" an image on a block device or converting with an device as target.
> > Currently creating as raw leads to 'Error while formatting' whereas using as
> > raw just works.
> >
> > With this patch raw is accepted for both files and host devices. For devices
> > the block driver is transparently changed to host_*.
> >     
>
> I agree that we should allow raw to also cover host devices, but I don't
> like the implementation very much.  Beeing used to specify the format is
> pretty much the only reason to have the name in the block driver anyway,
> and looking it up in one is a bit of a layering violation.
>   

I agree.

> I'd suggest to either allow multiple formats with the same name and
> looping over them or some sort of alias property in the block driver to
> also match the alias instead.
>   
Regards,

Anthony Liguori
>