[Qemu-devel] Re: [PATCH v2 05/11] tell kernel about all registers instead of just mp_state

[Jan Kiszka]

Gleb Natapov wrote:
> On Wed, Dec 02, 2009 at 01:10:22PM +0100, Jan Kiszka wrote:
>> Glauber Costa wrote:
>>>>> +{
>>>>> +    if (kvm_enabled()) {
>>>> Is this ever called or intended to be called when kvm is disabled?
>>>>
>>>>> +        kvm_cpu_flush_state(env);
>>>>> +    }
>>> I don't think so. But this is here for consistency with its synchronize 
>>> brother.
>> Ack. As soon as someone starts to use this generic service outside code
>> that is only built under CONFIG_KVM or called when kvm is enabled,
>> things will break.
>>
> We can add the check when adding first such user. Code outside
> CONFIG_KVM can't use this since the function is in kvm.h header.
> I don't have really strong opinion about that. I personally use
> kvm_enabled() as a hint that code is generic for kvm and non-kvm
> case when reading code.

It's the same case as with cpu_synchronize_state, just that the latter
is already used outside kvm code. Both services logically belong into a
different header but are in kvm.h for simplicity reasons.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux