[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] vmstate: Fix info field of VMSTATE_MACADDR
From: |
Juan Quintela |
Subject: |
[Qemu-devel] Re: [PATCH] vmstate: Fix info field of VMSTATE_MACADDR |
Date: |
Tue, 01 Dec 2009 20:24:38 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Jan Kiszka <address@hidden> wrote:
> Signed-off-by: Jan Kiszka <address@hidden>
> ---
>
> This may partly or fully explain the e1000 issue Pierre reported first.
> However, there are more bugs in the current migration code, e.g. in
> qemu_fseek when used with streams, it still doesn't work properly here.
> Need a break...
You arrived at the same conclussion than me :(
> hw/hw.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/hw.h b/hw/hw.h
> index 86ee716..dc119f0 100644
> --- a/hw/hw.h
> +++ b/hw/hw.h
> @@ -546,7 +546,7 @@ extern const VMStateDescription vmstate_i2c_slave;
> #define VMSTATE_MACADDR(_field, _state) { \
> .name = (stringify(_field)), \
> .size = sizeof(MACAddr), \
> - .info = &vmstate_info_uint8, \
> + .info = &vmstate_info_buffer, \
> .flags = VMS_BUFFER, \
> .offset = vmstate_offset_macaddr(_state, _field), \
> }
Good catch.
Later, Juan.