Re: [Qemu-devel] [PATCH 5/7] tell kernel about all registers instead of just mp_state

[Gleb Natapov]

On Mon, Nov 30, 2009 at 09:45:56AM -0200, Glauber Costa wrote:
> >> since
> >> +     * apic base was just updated
> >> +     */
> >> +    kvm_arch_put_registers(s->cpu_env);
> >>
> >>
> >
> > Better to use cpu_synchronize_state() instead.
> >
> I might be misreading it, but :
> 
> void kvm_cpu_synchronize_state(CPUState *env)
> {
>     if (!env->kvm_state->regs_modified) {
>         kvm_arch_get_registers(env);
>         env->kvm_state->regs_modified = 1;
>     }
> }
> 
> Only does get. And we need put.
> 
Put is on the entry into the kernel in vcpu_run.

--
                        Gleb.