[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test
From: |
Kevin O'Connor |
Subject: |
[Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test |
Date: |
Sun, 22 Nov 2009 12:07:50 -0500 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Sun, Nov 22, 2009 at 04:08:53PM +0200, Gleb Natapov wrote:
> Microsoft SVVP (Server Virtualization Validation Program) expects
> arbitrary SMBIOS field to have certain values otherwise it fails.
> We all want to make Microsoft happy don't we? So lets put values MS
> expects in there.
[...]
> - load_str_field_or_skip(1, manufacturer_str);
> - load_str_field_or_skip(1, product_name_str);
> + load_str_field_with_default(1, manufacturer_str, "QEMU");
> + load_str_field_with_default(1, product_name_str, "QEMU");
> load_str_field_or_skip(1, version_str);
> load_str_field_or_skip(1, serial_number_str);
Can the CONFIG_APPNAMExx defines in config.h be used instead of hard
coding QEMU? (If desired, the defaults can be changed from bochs to
qemu.)
> - memcpy((char *)start, "CPU " "\0" "" "\0" "", 7);
> - ((char *)start)[4] = cpu_number + '0';
> + memcpy((char *)start, "CPU \0QEMU\0\0", 12);
> + ((char *)start)[4] = cpu_number + '0';
BTW, snprintf can now be used here.
-Kevin
- [Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test, (continued)
- [Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test, Sebastian Herbszt, 2009/11/25
- [Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test, Gleb Natapov, 2009/11/26
- [Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test, Sebastian Herbszt, 2009/11/26
- Re: [Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test, Yaniv Kaul, 2009/11/22
- Re: [Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test, Carl-Daniel Hailfinger, 2009/11/22
- Re: [Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test, Gleb Natapov, 2009/11/23
- Re: [Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test, Sebastian Herbszt, 2009/11/23
- [Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test, Gleb Natapov, 2009/11/23
[Qemu-devel] Re: [PATCH][SEABIOS] Make SMBIOS table pass MS SVVP test,
Kevin O'Connor <=