Re: [Qemu-devel] [PATCH 05/15] scsi: move scsi command from SCSIGenericR

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 05/15] scsi: move scsi command from SCSIGenericR

From:	Paul Brook
Subject:	Re: [Qemu-devel] [PATCH 05/15] scsi: move scsi command from SCSIGenericReq to SCSIRequest.
Date:	Tue, 17 Nov 2009 11:55:37 +0000
User-agent:	KMail/1.12.2 (Linux/2.6.30-2-amd64; KDE/4.3.2; x86_64; ; )

> move scsi command from SCSIGenericReq to SCSIRequest.

Why? AFAICS This has precisely one user, and more importantly it is not 
populated by scsi-disk.c.

Sharing common code is good. Implementing shared fields inconsistently or 
putting implementation specific fields in common structures.

Paul

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [Qemu-devel] [PATCH 03/15] scsi: move request lists to QTAILQ., (continued)
- [Qemu-devel] [PATCH 06/15] scsi: move blocksize from SCSIGenericState to SCSIDevice, Gerd Hoffmann, 2009/11/17
  - Re: [Qemu-devel] [PATCH 06/15] scsi: move blocksize from SCSIGenericState to SCSIDevice, Christoph Hellwig, 2009/11/17
- [Qemu-devel] [PATCH 02/15] scsi: create common SCSIRequest structure., Gerd Hoffmann, 2009/11/17
  - Re: [Qemu-devel] [PATCH 02/15] scsi: create common SCSIRequest structure., Christoph Hellwig, 2009/11/17
- [Qemu-devel] [PATCH 08/15] scsi: move type from SCSIGenericState to SCSIDevice, Gerd Hoffmann, 2009/11/17
  - Re: [Qemu-devel] [PATCH 08/15] scsi: move type from SCSIGenericState to SCSIDevice, Christoph Hellwig, 2009/11/17
- [Qemu-devel] [PATCH 05/15] scsi: move scsi command from SCSIGenericReq to SCSIRequest., Gerd Hoffmann, 2009/11/17
  - Re: [Qemu-devel] [PATCH 05/15] scsi: move scsi command from SCSIGenericReq to SCSIRequest., Christoph Hellwig, 2009/11/17
  - Re: [Qemu-devel] [PATCH 05/15] scsi: move scsi command from SCSIGenericReq to SCSIRequest., Paul Brook <=
    - Re: [Qemu-devel] [PATCH 05/15] scsi: move scsi command from SCSIGenericReq to SCSIRequest., Gerd Hoffmann, 2009/11/17
- [Qemu-devel] [PATCH 12/15] scsi: move sense to SCSIDevice, create SCSISense struct., Gerd Hoffmann, 2009/11/17
  - Re: [Qemu-devel] [PATCH 12/15] scsi: move sense to SCSIDevice, create SCSISense struct., Christoph Hellwig, 2009/11/17
    - Re: [Qemu-devel] [PATCH 12/15] scsi: move sense to SCSIDevice, create SCSISense struct., Gerd Hoffmann, 2009/11/17
- [Qemu-devel] [PATCH 09/15] scsi: move scsi request parsing into generic code., Gerd Hoffmann, 2009/11/17
  - Re: [Qemu-devel] [PATCH 09/15] scsi: move scsi request parsing into generic code., Christoph Hellwig, 2009/11/17
    - Re: [Qemu-devel] [PATCH 09/15] scsi: move scsi request parsing into generic code., Paul Brook, 2009/11/17
    - Re: [Qemu-devel] [PATCH 09/15] scsi: move scsi request parsing into generic code., Gerd Hoffmann, 2009/11/17
    - Re: [Qemu-devel] [PATCH 09/15] scsi: move scsi request parsing into generic code., Paul Brook, 2009/11/17
- [Qemu-devel] [PATCH 10/15] scsi: use command defines in scsi-disk.c, Gerd Hoffmann, 2009/11/17

Prev by Date: Re: [Qemu-devel] [PATCH 12/15] scsi: move sense to SCSIDevice, create SCSISense struct.
Next by Date: Re: [Qemu-devel] [PATCH 11/15] scsi: add xfer mode
Previous by thread: Re: [Qemu-devel] [PATCH 05/15] scsi: move scsi command from SCSIGenericReq to SCSIRequest.
Next by thread: Re: [Qemu-devel] [PATCH 05/15] scsi: move scsi command from SCSIGenericReq to SCSIRequest.
Index(es):
- Date
- Thread