Re: [Qemu-devel] [sneak preview] major scsi overhaul

[Blue Swirl]

On Sat, Nov 7, 2009 at 1:09 AM, Gerd Hoffmann <address@hidden> wrote:
>  Hi,
>
> http://repo.or.cz/w/qemu/kraxel.git/shortlog/refs/heads/scsi.v6
>
> What is in there?
>
>  (1) Reworked scsi data structures.  There is a SCSIRequest struct now.
>  (2) Restructed emulation in the scsi-disk driver.
>  (3) New interface for HBA <=> SCSIDevice interaction:
>      * building on the new SCSIRequest struct.
>      * the silly read_data/write_data ping-pong game is gone.
>      * support for scatter lists and zerocopy I/O is there.

Cool.

>  (4) Added support for the new interface to scsi-disk and scsi-generic.
>  (5) Switched esp and usb-storage to the new interface.
>      * fixed usb-storage state engine along the way.  And, no, a
>        backport to stable isn't going to happen.  With the new
>        interface state tracking is simpler and easier to get right.
>  (6) A bunch of misc fixes and improvements.
>
> What needs to be done?
>
>  (1) Better patch descriptions.
>  (2) Submit patches to the list for review.
>  (3) Switch over lsi to the new interface.
>  (4) Zap old interface, killing tons of dead code.
>  (5) Final cleanups.

In general the commits look good, there are many obviously correct cleanups.

However, what happens to the DPRINTFs, it looks like they are removed
in the process?

You are also moving the compilation to Makefile.hw, which is not
exactly an improvement. Is this needed because of the QEMUIOVector
stuff?