qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] v3: don't call reset functions on cpu initiali


From: Laurent Desnogues
Subject: Re: [Qemu-devel] [PATCH] v3: don't call reset functions on cpu initialization
Date: Fri, 6 Nov 2009 20:13:19 +0100

On Fri, Nov 6, 2009 at 8:01 PM, Blue Swirl <address@hidden> wrote:
> On Fri, Nov 6, 2009 at 8:43 PM, Laurent Desnogues
> <address@hidden> wrote:
[...]
>> I honestly don't care that much as long as all targets still work
>> in user mode :-)
>>
>> The aim was to make Glauber's patch less intrusive.
>
> Given that only the new calls to cpu_reset are important and the
> removals are much less so (double reset shouldn't be a problem), the
> least intrusive version would be to just add the new calls and do the
> clean up later.

Multiple resets would result in memory leaks for MIPS for instance.
So I don't think they are that innocuous.  Though that probably is
more a problem of the MIPS reset than anything else :-)


Laurent




reply via email to

[Prev in Thread] Current Thread [Next in Thread]