[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] isa: configure serial+parallel by index.
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] isa: configure serial+parallel by index. |
Date: |
Mon, 26 Oct 2009 09:56:05 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Markus Armbruster <address@hidden> writes:
> Gerd Hoffmann <address@hidden> writes:
>
>> This patch adds a 'index' property to the isa-parallel and isa-serial
>> devices. This can be used to create devices with the default isa irqs
>> and ioports by simply specifying the index, i.e.
>>
>> -device isa-serial,index=1
>>
>> instead of
>>
>> -device isa-serial,iobase=0x2f8,irq=3
>>
>> for ttyS1 aka com2. Likewise for parallel ports.
>
> Not mentioned here, only in the code:
>
> * index defaults to 0 for the first device to initialize, 1 for the
> second, and so forth.
>
> * It is okay to overwrite the defaults provided by index, e.g.
>
> -device isa-serial,index=1,irq=4
>
> Looks fine to me. A similar solution could do for default mac address.
One little thing I missed on first reading: making an index property
hexadecimal is weird. I'd really expect decimal there.