qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] Makefile: Change make to be quiet again when do


From: Paolo Bonzini
Subject: [Qemu-devel] Re: [PATCH] Makefile: Change make to be quiet again when doing nothing
Date: Thu, 22 Oct 2009 08:21:50 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4

On 10/21/2009 11:17 PM, Stefan Weil wrote:
Paolo Bonzini schrieb:
On 10/20/2009 06:17 PM, Stefan Weil wrote:
This patch makes make quiet again.

There is already a similar patch from Juan Quintela,
but maybe this shorter form is preferred.

This patch would reintroduce an ordering problem between building
config*.h and building the tools, whose fix is what made "make" noisy
in the first place.

Paolo

Did you try this? config*.h will be built first, tools and docs come
later with my patch,
so there should not be any difference regarding the build order.

No, but if there is a hidden missing dependency I don't see how your patch could work, that's it. I know that the patch is "in theory" correct, but people were reporting failed builds and Juan's move of $(TOOLS) $(DOCS) solved it.

Consider in addition that make does not guarantee to even *start* A before B if you have "TARGET: A B", especially at very high parallelism. If you have icecream installed, a make -j20 is not uncommon and guaranteed to find wrong dependencies.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]