Re: [Qemu-devel] [PATCH 08/10] monitor: Convert bdrv_info() to QObject

[Markus Armbruster]

Luiz Capitulino <address@hidden> writes:

> On Sat, 10 Oct 2009 14:18:03 +0200
> Markus Armbruster <address@hidden> wrote:
>
>> Luiz Capitulino <address@hidden> writes:
>> 
>> > Each block device information is stored in a QDict and the
>> > returned QObject is a QList of all devices.
>> >
>> > The QDict contains the following:
>> >
>> > - "device": device name
>> > - "type": device type
>> > - "removable": 1 if the device is removable 0 otherwise
>> > - "locked": 1 if the device is locked 0 otherwise
>> > - "backing_file": backing file name if one is used
>> 
>> Isn't this in "interted" rather than here?
>> 
>> If yes, the comment in the code needs fixing, too.
>
>  Yes, although I don't think I should resend just because of that.

Any other way to reliably avoid commit of a misleading comment with a
misleading commit message?

If it goes in that way, we need to follow up with a commit fixing the
comment.