qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 5/9] monitor: QError support


From: Paolo Bonzini
Subject: [Qemu-devel] Re: [PATCH 5/9] monitor: QError support
Date: Wed, 14 Oct 2009 15:14:33 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-2.7.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4

On 10/13/2009 11:59 PM, Markus Armbruster wrote:
>  +void qemu_error_structed(QErrorCode code, const char *fmt, ...);
Needs __attribute__((format(printf, 2, 3))).

If I read the code correctly, qemu_object_from_va is what in the end processes the valist and it is not exactly compatible with printf syntax. For example, in patch 7/9 you have

     qemu_error_structed(QERR_QDEV_NFOUND, "{ s: s }", "name", driver);

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]