|
From: | Anthony Liguori |
Subject: | [Qemu-devel] Re: Commit 99a0949 (using the mailing list) |
Date: | Thu, 01 Oct 2009 17:06:14 -0500 |
User-agent: | Thunderbird 2.0.0.23 (X11/20090825) |
Anthony Liguori wrote:
I've reverted 99a0949. It's not necessarily a bad change to make but something that's so invasive as that absolutely requires some discussion before hand. Avoiding "bike-shedding" is not a valid argument for avoiding the list.For instance, I find the naming to be truly awful and would have liked some discussion on a more reasonable naming convention.I have a very large set of patches in my queue (over 200) that I'm testing and trying to commit. A lot of other people do. If we're going to make a change like this, it's very important to coordinate with people so that they can flush their queues and avoid massive merge head-ache.
After talking to malc, I have to take a fair bit of the blame here. I made a comment in another thread that I thought that this sort of change was a good idea. While I do think it's a good idea, I could have been more clear that it was a change that needed some more planning and discussion.
Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |