Re: [Qemu-devel] Re: [RfC PATCH 1/3] net: macaddr tweaks.

[Blue Swirl]

On Wed, Sep 30, 2009 at 2:57 PM, Paolo Bonzini <address@hidden> wrote:
>
>> +void qemu_macaddr_default_if_unset(macaddr_t macaddr)
>> +{
>> +    macaddr_t zero = { 0,0,0,0,0,0 };
>
> Very minor since this is not at all a hot path, but please make it just
>
>  static macaddr_t zero;
>
> since otherwise it would be initialized on the stack at run time.

Even better, static const.