Re: [Qemu-devel] Re: [PATCHv2] qemu: target library, use it in msix

[Michael S. Tsirkin]

On Tue, Sep 29, 2009 at 06:26:14PM +0200, Avi Kivity wrote:
> On 09/29/2009 05:57 PM, Michael S. Tsirkin wrote:
>>
>>> There is no such requirement anymore (since r2868 in 2007), devices
>>> can register regions of arbitrary size and multiple devices can share
>>> a page.
>>>      
>> Why does the comment on top of cpu_register_physical_memory_offset say
>> otherwise then? Also, this function seems to call kvm_set_phys_mem,
>> which also, apparently, assumes target page alignment.
>>    
>
> That's only for RAM, which the msix area isn't.

OK, looks like things should just work defining MSIX_PAGE_SIZE to 0x1000 then.
Unsurprisingly, this works fine on intel here.

> -- 
> error compiling committee.c: too many arguments to function