Re: [Qemu-devel] [PATCH] Fix exit on 'pci_add' Monitor command

[Markus Armbruster]

Luiz Capitulino <address@hidden> writes:

> On Thu, 24 Sep 2009 20:12:30 +0200
> Markus Armbruster <address@hidden> wrote:
[...]
>> My major complaint is that I'd rather see the code cleaned up there.
>> It's perfectly fine for code that can run only during startup to
>> terminate the program on configuration error.  Code to be used after
>> startup (used from monitor, in particular) must not do that.  Instead,
>> it should return failure up the call chain, until we reach either
>> startup code or monitor code, where the policy how to handle the error
>> resides.
>
>  What cleanup do you suggest?
>
>  Note that it's not only about exit(), the function also has some
> fprintf()s. If a big refactor is needed to properly fix this,
> I guess we will have to live with the bug for a long time...

See the patch series I'm going to post.