[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/6] Fix pci_vga_init() not to ignore bus argument
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 1/6] Fix pci_vga_init() not to ignore bus argument |
Date: |
Fri, 25 Sep 2009 03:53:48 +0200 |
Commit a414c306 converted all VGA devices to qdev. It used
pci_create_simple() for all devices, except for this one it used
pci_create(). That's wrong, because it uses PCI bus#0 regardless of
the bus argument. Fix by switching to pci_create_noinit().
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/vga-pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/vga-pci.c b/hw/vga-pci.c
index 6038cec..129ff48 100644
--- a/hw/vga-pci.c
+++ b/hw/vga-pci.c
@@ -137,7 +137,7 @@ int pci_vga_init(PCIBus *bus,
{
PCIDevice *dev;
- dev = pci_create("VGA", NULL);
+ dev = pci_create_noinit(bus, -1, "VGA");
qdev_prop_set_uint32(&dev->qdev, "bios-offset", vga_bios_offset);
qdev_prop_set_uint32(&dev->qdev, "bios-size", vga_bios_offset);
qdev_init(&dev->qdev);
--
1.6.2.5
- [Qemu-devel] [PATCH 0/6] Fix pci_add not to exit on error & other fixes, Markus Armbruster, 2009/09/24
- [Qemu-devel] [PATCH 2/6] Fix pci_add storage not to exit on bad first argument, Markus Armbruster, 2009/09/24
- [Qemu-devel] [PATCH 1/6] Fix pci_vga_init() not to ignore bus argument,
Markus Armbruster <=
- [Qemu-devel] [PATCH 6/6] Rename pci_create_noinit() to pci_create(), Markus Armbruster, 2009/09/24
- [Qemu-devel] [PATCH 4/6] Fix pci_add nic not to exit on bad model, Markus Armbruster, 2009/09/24
- [Qemu-devel] [PATCH 3/6] Make it obvious that pci_nic_init() can't fail, Markus Armbruster, 2009/09/24
- [Qemu-devel] [PATCH 5/6] pci_create() is now unused, remove it, Markus Armbruster, 2009/09/24
- Re: [Qemu-devel] [PATCH 0/6] Fix pci_add not to exit on error & other fixes, Gerd Hoffmann, 2009/09/25
- Re: [Qemu-devel] [PATCH 0/6] Fix pci_add not to exit on error & other fixes, Luiz Capitulino, 2009/09/25
- Re: [Qemu-devel] [PATCH 0/6] Fix pci_add not to exit on error & other fixes, Mark McLoughlin, 2009/09/28