[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qdev: show failing device name instead of silen
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] qdev: show failing device name instead of silently exiting |
|
Date: |
Thu, 24 Sep 2009 15:30:27 +0200 |
|
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) |
Amit Shah <address@hidden> writes:
> Hey Markus,
>
> On (Wed) Sep 23 2009 [22:53:27], Markus Armbruster wrote:
>> Amit Shah <address@hidden> writes:
>>
>> > If initializing a device fails, show the name of the device
>> > and then exit
>>
>> "and then exit" is misleading, as you don't add an exit.
>
> The 'return NULL' does that -- the calling function exits.
> (doesn't the subject line clarify that?)
You could say "show the name of the device before exiting".
The message as you worded it made me look for an exit where there wasn't
one before.