[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] eepro100: Fix format strings in debug messages
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCH] eepro100: Fix format strings in debug messages |
Date: |
Sat, 19 Sep 2009 12:55:29 +0200 |
User-agent: |
Mozilla-Thunderbird 2.0.0.22 (X11/20090707) |
Reimar Döffinger schrieb:
> On Sat, Sep 19, 2009 at 12:37:51PM +0200, Stefan Weil wrote:
>
>> size_t arguments need %zu instead of %d.
>>
>> This patch is a step to synchronize my maintainer version
>> of eepro100.c (git://repo.or.cz/qemu/ar7.git) with the
>> version integrated in QEMU.
>>
>
> MinGW probably won't know about "zu". Casting size to uint64_t and using
> PRIu64 would be an option, as well as just ignoring MinGW.
>
Yes, this is a well known problem (a lot of QEMU code uses %zu or %zd).
Ignoring MinGW is probably the best solution here because only debugging
code is concerned. The problem will disappear as soon as Windows
provides a better printf family :-)
Regards
Stefan