[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] set correct CS seg limit and flags on sipi
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH] set correct CS seg limit and flags on sipi |
Date: |
Sun, 13 Sep 2009 13:34:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Gleb Natapov wrote:
> TCG works with incorrect values somehow.
TCG doesn't care about limits and has only few segment type checks.
Some link to the corresponding spec section would be nice-to-have in
this commit message. I was looking for a reference what registers SIPIs
actually modify and how, but there seems to be none, at least in the
System Programming Guide.
>
> Signed-off-by: Gleb Natapov <address@hidden>
> diff --git a/hw/apic.c b/hw/apic.c
> index 2c414c1..c89008e 100644
> --- a/hw/apic.c
> +++ b/hw/apic.c
> @@ -516,7 +516,7 @@ void apic_sipi(CPUState *env)
>
> env->eip = 0;
> cpu_x86_load_seg_cache(env, R_CS, s->sipi_vector << 8, s->sipi_vector <<
> 12,
> - 0xffff, 0);
> + env->segs[R_CS].limit, env->segs[R_CS].flags);
> env->halted = 0;
> s->wait_for_sipi = 0;
> }
> --
> Gleb.
Jan
signature.asc
Description: OpenPGP digital signature