[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] Move function definitions out of xilinx.h
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 1/6] Move function definitions out of xilinx.h |
Date: |
Sat, 12 Sep 2009 09:04:17 +0300 |
On Fri, Sep 11, 2009 at 11:19 PM, Markus Armbruster <address@hidden> wrote:
> xilinx.h defines a couple of static inline functions for creating
> devices. While that's a fair technique for hot functions, device
> initialization is about as cold as it gets. Define them in the device
> source files instead, and keep only declarations in the header.
If I understood the qdev plan correctly, this is going to wrong
direction. These functions should reside near the instantiation, not
in the device code. The current approach looks OK if there are going
to be more users of the devices.
- [Qemu-devel] [PATCH 0/6] Clean up use of qdev_init(), Markus Armbruster, 2009/09/11
- [Qemu-devel] [PATCH 4/6] New qdev_init_nofail(), Markus Armbruster, 2009/09/11
- [Qemu-devel] [PATCH 6/6] Warn if value of qdev_init() isn't checked, Markus Armbruster, 2009/09/11
- [Qemu-devel] [PATCH 3/6] Check return value of qdev_init(), Markus Armbruster, 2009/09/11
- [Qemu-devel] [PATCH 2/6] Make qdev_init() destroy the device on failure, Markus Armbruster, 2009/09/11
- [Qemu-devel] [PATCH 5/6] Make isa_create() terminate program on failure, Markus Armbruster, 2009/09/11
- [Qemu-devel] [PATCH 1/6] Move function definitions out of xilinx.h, Markus Armbruster, 2009/09/11
- Re: [Qemu-devel] [PATCH 1/6] Move function definitions out of xilinx.h,
Blue Swirl <=
- Re: [Qemu-devel] [PATCH 1/6] Move function definitions out of xilinx.h, Edgar E. Iglesias, 2009/09/12
- Re: [Qemu-devel] [PATCH 1/6] Move function definitions out of xilinx.h, Gerd Hoffmann, 2009/09/14
- Re: [Qemu-devel] [PATCH 1/6] Move function definitions out of xilinx.h, Edgar E. Iglesias, 2009/09/14
- Re: [Qemu-devel] [PATCH 1/6] Move function definitions out of xilinx.h, Blue Swirl, 2009/09/14
- Re: [Qemu-devel] [PATCH 1/6] Move function definitions out of xilinx.h, Markus Armbruster, 2009/09/14
- Re: [Qemu-devel] [PATCH 1/6] Move function definitions out of xilinx.h, Blue Swirl, 2009/09/14
Re: [Qemu-devel] [PATCH 0/6] Clean up use of qdev_init(), Gerd Hoffmann, 2009/09/14