[Qemu-devel] Re: [PATCH 03/26] Remove SaveVM v2 support

[Stefano Stabellini]

On Fri, 11 Sep 2009, Juan Quintela wrote:
> About this, nobody is wanting to remove useful features.  I was removing
> things that didn't work.  The best plan of action if you want v2 support
> on tree is to fix it.  Do what I did:
> 
> This commit introduces SaveVM v3
> commit 9366f4186025e1d8fc3bebd41fb714521c170b6f
> Author: aliguori <address@hidden>
> Date:   Mon Oct 6 14:53:52 2008 +0000
> 
>     Introduce v3 of savevm protocol
> 
> I checkout previous commit, savevm one machine. Go to the present and
> try to load it -> RAM don't work.
> 
> Search what commit broke it:
> 
> commit 94a6b54fd6d2d3321066cb4db7abeeb417af9365
> Author: pbrook <address@hidden>
> Date:   Sat Apr 11 17:15:54 2009 +0000
> 
>     Implement dynamic guest ram allocation.
> 
> Went to the previous one, to see if this was the only broken thing.
> And found that ide and vga was broken at that point.
> 
> I stopped searching there.
> You get that image to load, and I try not to break it with VMState
> changes.  Can you (or anybody else) got v2 to life?  If it is working,
> and you can use it, I don't want to break its support.  But if it has
> been broken for ages and nobody steps it to fix it -> removing is only
> useful thing that I can think of doing.

I really want to thank you for understanding; Ian and\or me will try to
fix this issue as soon as we can.


> > That said, I don't want to fight over this more than necessary, so as
> > long as you keep the per device loading functions in C we can maintain
> > v2 compatibility downstream if upstream is not interested.
> 
> Instead of complaining, we can start doing things productively.
> Can you do a list of the older (device, version) that you are interested
> in?  If we have such a list, we can see how feasible it is maintaing
> support for them.
> 

The list is not very long, and you'll find that most devices still have
the same version number:

I440FX version 2 (now is 3)
PIIX3 version 2 (now is 3)
cirrus_vga version 2 (now is 2)
vga version 2 (now is 2)
mc146818rtc version 1
serial version 2 (now is 3)
rtl8139 version 3 (now is 4)
ide version 2 (now is 3)
pckbd version 3 (now is 3)
ps2kbd version 3  (now is 3)
ps2mouse version 2  (now is 2)
dma version 1
fdc version 2  (now is 2)
UHCI usb controller version 1
gpe version 1
pcislots version 1
piix4acpi version 1